Add variances dispatch for distributions #8084
Open
+784
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegrabowski
added
enhancements
request discussion
help wanted
VI
jessegrabowski
force-pushed
the
variance
branch
from
91b1d5c to
9649395
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8084 +/- ##
==========================================
+ Coverage 90.80% 90.97% +0.16%
==========================================
Files 121 124 +3
Lines 19443 19714 +271
==========================================
+ Hits 17656 17935 +279
+ Misses 1787 1779 -8
🚀 New features to boost your workflow:
|
lucianopaz
approved these changes
Feb 2, 2026
Member
lucianopaz
left a comment
lucianopaz
left a comment
There was a problem hiding this comment.
LGTM. My only suggestion is that we move the maybe_resize utility from means and variances to utils.py, but I'll approve anyway and you can move it or not.
| return _variance(rv.owner.op, rv, *rv.owner.inputs) | ||
|
|
||
|
|
||
| def maybe_resize(a: TensorVariable, size) -> TensorVariable: |
Member
There was a problem hiding this comment.
Maybe this and the one in means should be moved to some common utility module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
variancefunction that returns the (symbolic) variance of a distribution. I added it because I thought it would be nice to have for the AutoGuide stuff; we can use themeanandvarianceof priors to initialize the parameters.This is a 90%+ LLM PR. I went through and tried to clean things up. I mostly copied the patterns from
mean.py.Related Issue
Checklist
Type of change